Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests sequentially and enforce tests in ROS 2 #28024

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Run tests sequentially and enforce tests in ROS 2 #28024

merged 3 commits into from
Sep 6, 2024

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Sep 5, 2024 •
edited
Loading

Purpose

Use sequential testing in ROS to prevent multiple tests from communicating traffic.
We also were only testing the test package, rather than ardupilot_sitl and ardupilot_msgs.
Because pre-commit isn't enforced, we had some style regressions I fixed, and now it's enforced in CI.

@Ryanf55 Ryanf55 force-pushed the run-tests-sequentially branch from c560e74 to 9afc48b Compare September 5, 2024 23:51
@Ryanf55 Ryanf55 requested a review from srmainwaring September 5, 2024 23:52
peterbarker
peterbarker requested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit messages need fixing

@Ryanf55 Ryanf55 force-pushed the run-tests-sequentially branch from 9afc48b to 3363a8e Compare September 6, 2024 01:57
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Sep 6, 2024

Commit messages need fixing

Fixed, oops.

@Ryanf55 Ryanf55 force-pushed the run-tests-sequentially branch from 3363a8e to 8bdc7ab Compare September 6, 2024 01:58
@peterbarker peterbarker merged commit 3e5bae9 into ArduPilot:master Sep 6, 2024
94 checks passed
@Ryanf55 Ryanf55 mentioned this pull request Sep 6, 2024
Merged
@Ryanf55 Ryanf55 deleted the run-tests-sequentially branch September 7, 2024 18:12
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Sep 7, 2024

Without this, you see this when testing:

[dds_udp.parm --synthetic-clock -14] bind port 5760 for SERIAL0
[dds_udp.parm --synthetic-clock -14] bind failed on port 5760 - Address already in use
[mavproxy.py -13] /bin/sh: 1: mavproxy.py: not found
[ERROR] [mavproxy.py -13]: process has died [pid 433252, exit code 127, cmd 'mavproxy.py  --out 127.0.0.1:14550  --out  127.0.0.1:14551  --master tcp:127.0.0.1:5760  --sitl 127.0.0.1:5501  --non-interactive '].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbarker peterbarker peterbarker approved these changes

@srmainwaring srmainwaring Awaiting requested review from srmainwaring

Assignees
No one assigned
Labels
BUG MergeOnCIPass ROS
Projects
DDS/ROS2
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ryanf55 @peterbarker